Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deserialize calls in doc comments #3933

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix deserialize calls in doc comments #3933

merged 1 commit into from
May 31, 2023

Conversation

chipshort
Copy link
Contributor

The renaming in wasmer 4 should be reflected in the doc comments.
deserialize_checked -> deserialize
deserialize -> deserialize_unchecked
It was missed in a few places.

@chipshort chipshort requested a review from syrusakbary as a code owner May 31, 2023 07:27
theduke
theduke approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theduke theduke enabled auto-merge (rebase) May 31, 2023 08:58
@theduke theduke merged commit 335bbbc into wasmerio:master May 31, 2023
@chipshort chipshort deleted the doc-fixes branch June 1, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipshort @theduke